[Prev][Next][Index][Thread]

Re: BUG (?) in oskit lance driver



I believe Kota Abe fixed this problem recently.  He can comment more on
his experience with the lance driver.  The fix goes something like this:

Index: lance.c
===================================================================
RCS file: /n/fast/usr/lsrc/flux/CVS/oskit/linux/src/drivers/net/lance.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -c -r1.6 -r1.7
*** lance.c	1999/11/11 00:53:24	1.6
--- lance.c	2000/11/13 21:54:30	1.7
***************
*** 366,372 ****
--- 366,381 ----
  int lance_probe(struct device *dev)
  {
  	int *port, result;
+ #ifdef OSKIT
+ 	static int first = 1;
  
+ 	if (first) {
+ 	    first = 0;
+ 	} else {
+ 	    return -ENODEV;
+ 	}
+ #endif
+ 
  	if (high_memory <= phys_to_virt(16*1024*1024))
  		lance_need_isa_bounce_buffers = 0;
  
***************
*** 805,811 ****
--- 814,824 ----
  		struct sk_buff *skb;
  		void *rx_buff;
  
+ #ifdef OSKIT
+ 		skb = alloc_skb(PKT_BUF_SZ, GFP_ATOMIC);
+ #else
  		skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp);
+ #endif
  		lp->rx_skbuff[i] = skb;
  		if (skb) {
  			skb->dev = dev;

Follow-Ups: